fix(web-ui): allow Tab focus traversal inside modal dialogs - #1568
Merged
Conversation
Keep the global IDE-style Tab block for app chrome, but let Tab move between fields in modal forms such as SSH connect and account login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[role="dialog"]/[aria-modal="true"]).Fixes #
Type and Areas
Type:
bug fix / UI/UX
Areas:
web UI
Motivation / Impact
Global Tab
preventDefaultinmain.tsxblocked focus traversal everywhere except Monaco and xterm. Modal forms (SSH connect, account login) could not Tab between fields. Users can now Tab inside dialogs; main chrome Tab behavior is unchanged.Verification
pnpm run type-check:web(pass)Reviewer Notes
Root cause is the capture-phase Tab blocker added in
5566db603(PR #150). This change only widens the allowlist; it does not remove the global blocker.Checklist